fix: remove comment

coinbase · Sep 13, 2024 · bd087b0 · bd087b0
1 parent e6a142f
commit bd087b0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/src/swap/components/SwapProvider.tsx b/src/swap/components/SwapProvider.tsx
@@ -267,15 +267,6 @@ export function SwapProvider({
       return;
     }
 
-    // is this needed?  odd to have init here
-    // updateLifeCycleStatus({
-    //   statusName: 'init',
-    //   statusData: {
-    //     isMissingRequiredField: false,
-    //     maxSlippage: initialMaxSlippage,
-    //   },
-    // });
-
     try {
       const maxSlippage = lifeCycleStatus.statusData.maxSlippage;
       const response = await buildSwapTransaction({

diff --git a/src/swap/types.ts b/src/swap/types.ts
@@ -105,9 +105,12 @@ export type LifeCycleStatusUpdate = LifeCycleStatus extends infer T
   ? T extends { statusName: infer N; statusData: infer D }
     ? { statusName: N } & (
       N extends "init"
-        ? { statusData: D } // leave statusData required if statusName is "init"
-        : AllKeysInShared<D> extends true // if statusData only contains LifeCycleStatusDataShared, make statusData optional
-          ? { statusData?: PartialKeys<D, keyof D & keyof LifeCycleStatusDataShared> } // make all keys in LifeCycleStatusDataShared optional
+        // leave statusData required if statusName is "init"
+        ? { statusData: D } 
+          // if statusData only contains LifeCycleStatusDataShared, make statusData optional
+        : AllKeysInShared<D> extends true 
+          // make all keys in LifeCycleStatusDataShared optional
+          ? { statusData?: PartialKeys<D, keyof D & keyof LifeCycleStatusDataShared> } 
           : { statusData: PartialKeys<D, keyof D & keyof LifeCycleStatusDataShared> }
       )
     : never