fixes

coinbase · Aug 14, 2024 · e262968 · e262968
1 parent 6874ac2
commit e262968
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/internal/svg/fundWallet.tsx b/src/internal/svg/fundWallet.tsx
@@ -4,9 +4,9 @@ export const FundWalletSvg = (
   <svg
     role="img"
     aria-label="fund-wallet-svg"
-    width="16"
-    height="16"
-    viewBox="0 0 16 16"
+    width="100%"
+    height="100%"
+    viewBox="0 0 20 20"
     fill="none"
     xmlns="http://www.w3.org/2000/svg"
   >

diff --git a/src/wallet/components/WalletDropdownFundLink.test.tsx b/src/wallet/components/WalletDropdownFundLink.test.tsx
@@ -52,7 +52,7 @@ describe('WalletDropdownFundLink', () => {
     // Check if window.open was called with the correct arguments
     expect(mockOpen).toHaveBeenCalledWith(
       expect.stringContaining('http://keys.coinbase.com/fund'),
-      'Coinbase Fund Wallet',
+      undefined,
       expect.stringContaining(
         'width=297,height=371,resizable,scrollbars=yes,status=1,left=364,top=199',
       ),
@@ -105,7 +105,7 @@ describe('WalletDropdownFundLink', () => {
       const expectedTop = Math.round((screenHeight - adjustedHeight) / 2);
       expect(mockOpen).toHaveBeenCalledWith(
         expect.stringContaining('http://keys.coinbase.com/fund'),
-        'Coinbase Fund Wallet',
+        undefined,
         expect.stringContaining(
           `width=${expectedWidth},height=${adjustedHeight},resizable,scrollbars=yes,status=1,left=${expectedLeft},top=${expectedTop}`,
         ),

diff --git a/src/wallet/components/WalletDropdownFundLink.tsx b/src/wallet/components/WalletDropdownFundLink.tsx
@@ -38,7 +38,7 @@ export function WalletDropdownFundLink({
     const windowFeatures =
       popupFeatures ||
       `width=${width},height=${height},resizable,scrollbars=yes,status=1,left=${left},top=${top}`;
-    window.open(fundingUrl, 'Coinbase Fund Wallet', windowFeatures);
+    window.open(fundingUrl, target, windowFeatures);
   };
 
   const overrideClassName = cn(