openIn=window -> popup

coinbase · Aug 14, 2024 · f162d4b · f162d4b
1 parent a9c6a57
commit f162d4b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/site/docs/pages/wallet/types.mdx b/site/docs/pages/wallet/types.mdx
@@ -90,10 +90,10 @@ export type WalletDropdownFundLinkReact = {
   href: string;
   icon?: ReactNode;
   rel?: string;
-  openIn?: 'window' | 'tab'; // Whether to open the funding flow in a tab or a window
+  openIn?: 'popup' | 'tab'; // Whether to open the funding flow in a tab or a popup window
   target?: string; // Where to open the target if `openIn` is set to tab
   text?: string; // Optional text override
-  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to window
+  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to `popup`
 };
 ```
 

diff --git a/src/wallet/components/WalletDropdownFundLink.test.tsx b/src/wallet/components/WalletDropdownFundLink.test.tsx
@@ -44,7 +44,7 @@ describe('WalletDropdownFundLink', () => {
     // Mock window.screen
     vi.stubGlobal('screen', { width: 1024, height: 768 });
 
-    render(<WalletDropdownFundLink openIn="window" />);
+    render(<WalletDropdownFundLink openIn="popup" />);
 
     const linkElement = screen.getByText('Fund wallet');
     fireEvent.click(linkElement);
@@ -84,7 +84,7 @@ describe('WalletDropdownFundLink', () => {
 
       render(
         <WalletDropdownFundLink
-          openIn="window"
+          openIn="popup"
           popupSize={size as keyof typeof testCases}
         />,
       );

diff --git a/src/wallet/types.ts b/src/wallet/types.ts
@@ -104,10 +104,10 @@ export type WalletDropdownFundLinkReact = {
   href: string;
   icon?: ReactNode;
   rel?: string;
-  openIn?: 'window' | 'tab'; // Whether to open the funding flow in a tab or a window
+  openIn?: 'popup' | 'tab'; // Whether to open the funding flow in a tab or a popup window
   target?: string; // Where to open the target if `openIn` is set to tab
   text?: string; // Optional text override
-  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to window
+  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to `popup`
 };
 
 /**