-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WalletDropdownFundLink
#1021
Changes from 1 commit
c62ca07
1f8aa0e
ae3e8dd
89112aa
ec45503
9212b30
5bb09e7
6468a62
7a98d5a
7d8fd70
c80f4b4
bff46b6
7495d92
a8dc224
48a926f
dd771bf
3cbe66f
3b5a079
83b0cc3
06ada06
7e0f393
d726dff
ad0127b
4252671
96597ca
48a25bc
c74b3a1
99816a0
5325599
7387e2d
2efd1d7
71ac9f5
320004a
c2d8dfe
a0f5829
c1d3365
a9c6a57
f162d4b
0ba3f3c
07d4bf3
5cda967
0b536ac
6874ac2
e262968
3f15e98
09e82f7
56a243a
a4ba654
91ee34e
df97e48
f040a52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
windowSize
-> popupSize
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,7 +93,7 @@ export type WalletDropdownFundLinkReact = { | |
openIn?: 'window' | 'tab'; // Whether to open the funding flow in a tab or a window | ||
target?: string; // Where to open the target if `openIn` is set to tab | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://www.w3schools.com/tags/att_a_target.asp
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks I was confusing the two There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think overall there is an interesting question to ask. What are properties we want to be able to customize and what we don't want to have customized. Otherwise it feels a weird overalap with the Link component. |
||
text?: string; // Optional text override | ||
windowSize?: 's' | 'm' | 'l'; // Size of the popup window if `openIn` is set to window | ||
popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to window | ||
}; | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this is a
popup
should we probably use that word instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a popup window but I like
window
abbreviation better sincepopup
has a negative connotation and makes it seems like it's spam (popup spam)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window
is a very special word in web. As it means both the global object, and the window browser size.I am kind of hesitant to use that word.