Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test coverage and remove console.log statement #1048

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

abcrane123
Copy link
Contributor

@abcrane123 abcrane123 commented Aug 14, 2024

What changed? Why?

  • add test coverage
  • remove console log statement in useWriteContracts because it is confusing to see error printed in console when txn is actually successful

Screenshot 2024-08-14 at 8 25 59 AM

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:30pm

@Zizzamia Zizzamia merged commit b222427 into main Aug 14, 2024
14 checks passed
@Zizzamia Zizzamia deleted the alissa.crane/tests branch August 14, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants