playground: enable Swap in preview
#1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Aug 22, 2024
|
|
||
| type EnvironmentKey = (typeof ENVIRONMENT)[keyof typeof ENVIRONMENT]; | ||
|
|
||
| export const ENVARS: Record<EnvironmentKey, string | undefined> = { |
There was a problem hiding this comment.
ENVARS sounds so evil.
Can we call it in a diffeerent way?
There was a problem hiding this comment.
renamed to ENVIRONMENT_VARIABLES (full name) if thats better 🤔
Zizzamia
reviewed
Aug 22, 2024
| @@ -94,7 +95,9 @@ function SwapComponent() { | |||
| token={usdcToken} | |||
| type="to" | |||
| /> | |||
| <SwapButton disabled={true} /> | |||
| <SwapButton | |||
| disabled={ENVARS[ENVIRONMENT.ENVIRONMENT] != 'development'} | |||
There was a problem hiding this comment.
btw, what you are looking is VERCEL_ENV === 'preview' which is different from NEXT_PUBLIC_VERCEL_ENV.
There was a problem hiding this comment.
We use this trick here for example https://github.com/coinbase/onchainkit/blob/main/playground/nextjs-app-router/next.config.mjs
There was a problem hiding this comment.
thanks - yep it's preview not development
however NEXT_PUBLIC prefix should work
0xAlec
changed the title
Swap in developmentSwap in preview
Zizzamia
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
ENVIRONMENT_VARIABLESmapSwapButtononly onproductiondeployments (i.e. onchainkit.xyz/playground)we can swap on preview deployments off PRs since they are behind authentication
Notes to reviewers
How has it been tested?
can swap on preview deployment attached to this PR