feat: Add Swap Settings #1210
feat: Add Swap Settings #1210
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/swap-settings-settings
branch
from
f2f1d28 to
be9cfd9
Compare
cpcramer
force-pushed
the
paul/swap-settings-settings
branch
from
be9cfd9 to
65f7462
Compare
|
|
||
| const [maxSlippage, _setMaxSlippage] = useState( | ||
| experimental.maxSlippage || 3, | ||
| ); |
There was a problem hiding this comment.
don't want this in state do we? If the experimental prop changes, should that update here?
There was a problem hiding this comment.
The experimental prop won't change after the component is rendered.
It will set the initial maxSlippage value. Any updates will be handled by LifeCycleStatus.slippageChange.maxSlippage property
There was a problem hiding this comment.
And we update this value using setLifeCycleStatus'
There was a problem hiding this comment.
Some context on why we are setting it this way
There was a problem hiding this comment.
If we are only using this const to initialize lifecycle status, can it just be a const? or alternatively we could move the initiallifecycle status into a const?
There was a problem hiding this comment.
The experimental prop won't change after the component is rendered.
@cpcramer that sentence it's incorrect! We should always expect a prop can change, that's the all point of prop. :)
| const maxSlippage = | ||
| lifeCycleStatus.statusName !== 'error' | ||
| ? lifeCycleStatus.statusData.maxSlippage | ||
| : 3; |
There was a problem hiding this comment.
If 3 is our default for everything, this should be in a share const.
There was a problem hiding this comment.
Follow up on this in the next PR.
What changed? Why?
Add
SwapSettingssub-component - we are not displaying it yet.Update
SwapSettingsSlippageInputAdd
maxSlippagefield tostatusDatain everyLifeCycleStatusexceptError.Notes to reviewers
How has it been tested?