Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt for wallet connection in TransactionButton #1216

Closed
wants to merge 4 commits into from

Conversation

0xAlec
Copy link
Contributor

@0xAlec 0xAlec commented Sep 5, 2024

What changed? Why?

  • do not disable Transaction if missing address
  • instead, prompt the user to connect their wallet

Notes to reviewers

How has it been tested?

  • playground

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:19pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:19pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:19pm

const handleSubmit = useCallback(() => {
const handleSubmit = useCallback(async () => {
if (!address) {
await connectAsync({ connector: connectors[0] });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid create a branch of developer experience by adding a new way to solve the same problem we did with #1173 .

We want to make sure both experience re-use Wallet logic, and do not create internal branch on how the same problem can be solved.

@cpcramer cpcramer closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants