Fix: Framegear with Multiple Text Inputs #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zizzamia
reviewed
Sep 6, 2024
| @@ -0,0 +1,34 @@ | |||
| import React, { createContext, useState, useContext, ReactNode } from 'react'; | |||
|
|
|||
| type TextInputsContextType = { | |||
There was a problem hiding this comment.
At some point we want to start organize the types in a types.ts file.
There was a problem hiding this comment.
Yeah I was wondering about that. And also moving the RedirectModalContext into contexts.
I'll do a little clean-up PR in the next couple days with some of those chores.
Zizzamia
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Currently, when using Framegear, if there are multiple frames with text input fields, the
inputTextstate will persist to the latter frames (ie. if a user inputs "blah" in the first input field, and the next frame has aninputfield, that field will be pre-filled with "blah"This PR fixes the issue by enabling Framegear to better handle multiple text inputs
TextInputscontextuseTextInputsinFrameInputandFrameto appropriately reset inputText state for various frame changesinputTextstate:FrameInput'sfetchbuttonpostorpost_redirectbutton clicks in theFramecomponentNotes to reviewers
How has it been tested?
locally