feat: set v2 as default API for Swap
#1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlec
changed the title
v2 as default API for Swapv2 as default API for Swap
cpcramer
approved these changes
Sep 13, 2024
abcrane123
approved these changes
Sep 13, 2024
alessey
approved these changes
Sep 13, 2024
Zizzamia
reviewed
Sep 14, 2024
| @@ -17,7 +17,7 @@ export function Swap({ | |||
| maxSlippage: DEFAULT_MAX_SLIPPAGE, | |||
| }, | |||
| className, | |||
| experimental = { useAggregator: true }, | |||
| experimental = { useAggregator: false }, | |||
There was a problem hiding this comment.
If we are switching, why keep all this extra code?
If we are confident in how it works, we should just remove all experimental code.
There was a problem hiding this comment.
Are we thinking to do that later? And later when?
There was a problem hiding this comment.
let's leave this option in for developers for now. will share the migration plan in Slack
Zizzamia
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
v1aggregator API (0x and 1inch)v2API by default (Uniswap)Notes to reviewers
How has it been tested?