chore: bump add docs for getEASAttestations
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zizzamia
reviewed
Feb 16, 2024
README.md
Outdated
| @@ -46,13 +46,13 @@ Add OnchainKit to your project, install the required packages. | |||
|
|
|||
| ```bash | |||
| # Use Yarn | |||
| yarn add @coinbase/onchainkit [email protected] react@18 react-dom@18 | |||
| yarn add @coinbase/onchainkit [email protected] react@18 react-dom@18 graphql@14 graphql-request@6 | |||
There was a problem hiding this comment.
So I am been thinking on this.
And as graphql@14 graphql-request@6 is required only for one utility, I think is best we mention to install that only in the page related to EAS.
A bit like some dependencies are common for the majority of the library, others are just for a few.
Than one that are for a few we explain to add them in their section.
There was a problem hiding this comment.
Actually let me see if I can make this a bit cuter
Zizzamia
reviewed
Feb 18, 2024
docs/identity-kit.md
Outdated
|
|
||
| The Ethereum Attestation Service (EAS) facilitates secure, decentralized attestations on the blockchain. We are launching functions to simplify accessing and managing these attestations across multiple blockchains, enhancing usability for developers and users. | ||
|
|
||
| ## getEASAttestations |
There was a problem hiding this comment.
Would you mind move this into his own doc file.
Zizzamia
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
bump add docs for
getEASAttestationsNotes to reviewers
How has it been tested?