feat: basic frame debugger #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zizzamia
reviewed
Feb 18, 2024
| @@ -0,0 +1,36 @@ | |||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | |||
|
|
|||
There was a problem hiding this comment.
nit. for next PR, do we need this? My guess is not
There was a problem hiding this comment.
ah probably not, was autogenerated. will clean up on the next one
There was a problem hiding this comment.
following up on this, worth including because after removing it there are ~1000 files git tries to track. Updating the outer .gitignore with this stuff would probably be confusing so going to keep it
Zizzamia
reviewed
Feb 18, 2024
|
|
||
| export function Header() { | ||
| return ( | ||
| <div className={`flex w-full flex-col items-center gap-8 border-b ${BORDER_COLOR} py-8`}> |
There was a problem hiding this comment.
nit. next PR start using clsx to better organize tailwind css
Zizzamia
reviewed
Feb 18, 2024
framegear/tailwind.config.ts
Outdated
|
|
||
| const config: Config = { | ||
| content: [ | ||
| "./pages/**/*.{js,ts,jsx,tsx,mdx}", |
There was a problem hiding this comment.
I believe we don't have pages so this could be removed
Zizzamia
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added a new directory,
framegear, at top level. This directory contains a standalone Next.js app which can validate the initial frame tags -- additional debugging and other features will be added in future PRs.We'll also want to determine how we want to ship this (e.g., if you globally install
onchainkitdoes this become an available command in your path?) in the near future.Notes to reviewers
How has it been tested?
Screen.Recording.2024-02-18.at.11.28.20.AM.mov