feat: add <Balance /> #155
Conversation
eragon512
force-pushed
the
comp/balance
branch
4 times, most recently
from
0d80ae6 to
e41b4dc
Compare
eragon512
force-pushed
the
comp/balance
branch
from
e41b4dc to
35e6066
Compare
| * @param {number} [decimalDigits=3] - Determines the no. of decimal digits to be displayed. | ||
| * @param {React.HTMLAttributes<HTMLSpanElement>} [props] - Additional HTML attributes for the span element. | ||
| */ | ||
| export function Balance({ address, className, decimalDigits = 3, ...props }: BalanceProps) { |
There was a problem hiding this comment.
Can we add this functionality to the avatar if possible?
There was a problem hiding this comment.
not sure if that's the best approach here - generally, it's best to keep each component small and atomic, with a single, clear responsibility
adding balance data to the avatar might add multiple responsibilities inside a single component
if users need balance data in their avatar, having a separate component allows them to stitch the avatar and balance components together in the way they feel fits their use case best
LMK your thoughts on this
There was a problem hiding this comment.
This week is hard for us to ship a new component.
Let's table this till the end of ETH Denver.
But, I love we at least started the convo.
|
Closing this for now, as |
What changed? Why?
Notes to reviewers
How has it been tested?
Unit test