feat: Add SwapLite util functions
#1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abcrane123
force-pushed
the
alissa.crane/fund-swap-utils
branch
from
4fb8ad3 to
3002cc4
Compare
abcrane123
changed the title
FundSwap util functionsSwapLite util functions
alessey
reviewed
Dec 16, 2024
| to.setAmountUSD(''), | ||
| ]); | ||
| }, [from, fromETH, fromUSDC, to]); | ||
| }; |
There was a problem hiding this comment.
nit: this may be more flexible accepting an array of SwapUnits, it seems like some of this logic could be shared between swap and lite
There was a problem hiding this comment.
created a ticket to refactor later
alessey
approved these changes
Dec 16, 2024
dschlabach
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
useResetSwapLiteInputs: resets to token, from token, USDC, and ETH balancesgetSwapLiteQuote: formats swap quote valuesuseSwapLiteTokens: returns token information (balance, etc) - for context, USDC and ETH will always be provided as swap options. users then have the ability to provide one morefromtoken to the componentNotes to reviewers
How has it been tested?