-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate nft #1714
Merged
Merged
refactor: migrate nft #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dschlabach
reviewed
Dec 10, 2024
src/ui/react/nft/index.ts
Outdated
Comment on lines
1
to
16
export { NFTMintCard } from './NFTMintCard'; | ||
export { NFTMintCardDefault } from './NFTMintCardDefault'; | ||
export { NFTCard } from './NFTCard'; | ||
export { NFTCardDefault } from './NFTCardDefault'; | ||
|
||
export type { | ||
BuildMintTransaction, | ||
LifecycleStatus, | ||
NFTCardReact, | ||
NFTCardDefaultReact, | ||
NFTData, | ||
NFTError, | ||
NFTMintCardReact, | ||
NFTMintCardDefaultReact, | ||
UseNFTData, | ||
} from '../../../core-react/nft/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update package.json exports
alessey
force-pushed
the
alessey/migrate-nft
branch
from
December 10, 2024 22:08
38ef084
to
b26601e
Compare
alessey
force-pushed
the
alessey/migrate-nft
branch
from
December 12, 2024 15:22
b26601e
to
7f43fa0
Compare
alessey
force-pushed
the
alessey/migrate-nft
branch
from
December 13, 2024 17:08
7f43fa0
to
e7ce06f
Compare
dschlabach
approved these changes
Dec 13, 2024
cpcramer
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Migrating NFT to the new architecture
Notes to reviewers
How has it been tested?