Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate nft #1714

Merged
merged 9 commits into from
Dec 16, 2024
Merged

refactor: migrate nft #1714

merged 9 commits into from
Dec 16, 2024

Conversation

alessey
Copy link
Contributor

@alessey alessey commented Dec 10, 2024

What changed? Why?
Migrating NFT to the new architecture

  • Moved common NFT providers/hooks to core-react/nft
  • Moved NFT components to ui/react/nft
  • Moved NFTPrice, ContractType, NFTError, TransactionError to core/types
  • Updated dependencies to aliases
  • Updated exports to point to new locations

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:02pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:02pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:02pm

Comment on lines 1 to 16
export { NFTMintCard } from './NFTMintCard';
export { NFTMintCardDefault } from './NFTMintCardDefault';
export { NFTCard } from './NFTCard';
export { NFTCardDefault } from './NFTCardDefault';

export type {
BuildMintTransaction,
LifecycleStatus,
NFTCardReact,
NFTCardDefaultReact,
NFTData,
NFTError,
NFTMintCardReact,
NFTMintCardDefaultReact,
UseNFTData,
} from '../../../core-react/nft/types';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update package.json exports

@github-actions github-actions bot added the root label Dec 10, 2024
@alessey alessey force-pushed the alessey/migrate-nft branch from 38ef084 to b26601e Compare December 10, 2024 22:08
@alessey alessey force-pushed the alessey/migrate-nft branch from b26601e to 7f43fa0 Compare December 12, 2024 15:22
@alessey alessey merged commit cad1eb3 into main Dec 16, 2024
16 checks passed
@alessey alessey deleted the alessey/migrate-nft branch December 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants