Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fund form #1718

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

Fund form #1718

wants to merge 47 commits into from

Conversation

rustam-cb
Copy link
Contributor

@rustam-cb rustam-cb commented Dec 11, 2024

What changed? Why?
Implemented a new component FundCard
P/PS: https://docs.google.com/document/d/1y57fxsga2ZLF8-ieH2OY7jvqx5468txQuek1WTYPBxE/edit?tab=t.0

Usage:

FundCard assetSymbol="ETH" /> 

Component is customizable and there are few components that can be passed into it.

  amountInputComponent 
  headerComponent
  amountInputTypeSwithComponent
  paymentMethodSelectorDropdownComponent
  submitButtonComponent
Fiat input Crypto input
Screenshot 2024-12-17 at 9 38 52 PM Screenshot 2024-12-17 at 9 39 06 PM
No input (default) payment method dropdown
Screenshot 2024-12-17 at 9 38 41 PM Screenshot 2024-12-17 at 9 39 20 PM

Notes to reviewers
Overall component structure:

  • FundCard
    • HeaderComponent
    • AmountInputComponent
    • PaymentMethodDropdownComponent
    • SubmitButtonComponent

How has it been tested?

  • Unit tests
  • Manual testing

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:15am
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:15am
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:15am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg: fund pkg: styles pkg: swap root
Development

Successfully merging this pull request may close these issues.

1 participant