Chore: Wallet Refactor #1732
Open
Chore: Wallet Refactor #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
reviewed
Dec 13, 2024
| <WalletBasic> | ||
| <ConnectWallet /> | ||
| <WalletDropdown /> | ||
| </WalletBasic> |
There was a problem hiding this comment.
won't wallet island and and current share the connect wallet components? would't the only change be <WalletDropdown/> vs. <WalletIsland/>?
There was a problem hiding this comment.
yes, that's correct. The reason for this change is that WalletBasic is opinionated about children, destructuring and reorganizing them.
There was a problem hiding this comment.
is it possible to use a single top level node and then look for WalletDropdown or WalletIsland to determine which? If a user added WalletIsland and WalletDropdown child components we could just log an error and choose the first one to display.
alessey
reviewed
Dec 13, 2024
dschlabach
reviewed
Dec 13, 2024
cpcramer
reviewed
Dec 13, 2024
cpcramer
reviewed
Dec 13, 2024
cpcramer
reviewed
Dec 13, 2024
cpcramer
reviewed
Dec 13, 2024
brendan-defi
force-pushed
the
chore/wallet-refactor
branch
from
9b240e7 to
93df3be
Compare
alessey
reviewed
Dec 16, 2024
alessey
reviewed
Dec 16, 2024
brendan-defi
force-pushed
the
chore/wallet-refactor
branch
from
1d28f36 to
d3ea6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?
locally, vitest