Chore: Swap Refactors #1733
Chore: Swap Refactors #1733
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/swap/components/Swap.tsx
Outdated
| @@ -75,6 +76,7 @@ export function Swap({ | |||
| data-testid="ockSwap_Container" | |||
| > | |||
| <div className="mb-4 flex items-center justify-between"> | |||
| {backButton} | |||
There was a problem hiding this comment.
What's the backButton for again?
There was a problem hiding this comment.
I need a backbutton in walletisland's implementation of swap
There was a problem hiding this comment.
To me this feels like something that should live outside of Swap. I don't think that we want to ship that option to third party consumers of the component.
Could it instead be a button that's positioned absolutely to the parent? I think that'd make more sense than adding a backButton prop
There was a problem hiding this comment.
the issue is how to center the title between the backbutton and the settings button.
the parent container for these is set to justify-between. this is the correct default behavior. i have not figured out a way to override this from "within" the container — that is, no class directive on the swap-title makes it center-aligned.
AFAICT, i need a third element so that the title will move to the center.
There was a problem hiding this comment.
The best that I can come up with is to make the topbar relative, wrap swapSettings in a div, and make that div absolutely-positioned with right-0.
brendan-defi
force-pushed
the
chore/swap-refactor
branch
from
95761cd to
d0de460
Compare
|
closing in favor of a cleaner branch |
What changed? Why?
Notes to reviewers
How has it been tested?
locally