fix: fix path resolution issue in cli.ts #1748
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update addresses an issue with path resolution in the following code snippet:
Previous Code
Problem
The
fileURLToPath(import.meta.url)
function returns the absolute path to the current file, but passing it directly intopath.resolve
without usingpath.dirname
can cause problems. This is particularly an issue if the file's path contains special characters (e.g.,%20
for spaces), as it may not be decoded properly.Fix
The code now explicitly extracts the directory name using
path.dirname
, ensuring robust path resolution:Why This Matters
fileURLToPath(import.meta.url)
provides the file path, not the directory.path.dirname
ensures the proper resolution of relative paths, making the code more reliable and compatible with various environments.This change improves the overall resilience and compatibility of the file resolution logic.