Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: always show required tag status #176

Merged
merged 4 commits into from
Feb 22, 2024
Merged

feat: always show required tag status #176

merged 4 commits into from
Feb 22, 2024

Conversation

cnasc
Copy link
Contributor

@cnasc cnasc commented Feb 22, 2024 •
edited
Loading

What changed? Why?
Part of #146. Changes in this PR:

  • always show required tags, even when not present
  • show error message when relevant in verification
  • add placeholder message when no frame has been loaded
  • update schema for more consistent error messages (wording around "required" vs "defined")

Small improvements while I was in there:

  • we didn't gracefully handle wrong aspect-ratio image, now using object-cover to clip the edges to fit. This is consistent with Warpcast behavior.
  • Handled long frame button text with ellipsis
no results invalid results valid results
image image image

Notes to reviewers

How has it been tested?

@cnasc cnasc requested a review from Zizzamia February 22, 2024 17:00
@cnasc cnasc mentioned this pull request Feb 22, 2024
Closed
19 tasks
@cnasc cnasc changed the title feat: group tag verification into required/optional feat: always show required tag status Feb 22, 2024
@Zizzamia Zizzamia merged commit 8b9937e into main Feb 22, 2024
9 checks passed
@Zizzamia Zizzamia deleted the cjn/required-optional branch February 22, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zizzamia Zizzamia Zizzamia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnasc @Zizzamia