-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add required peer deps to the framegear package #187
Conversation
Hi @DonGambas, if these are the warnings you're talking about:
framegear doesn't use any code from onchainkit that requires them, which is why they aren't installed |
Hey @cnasc, those are the warnings that are raised at point of package install (which doens't seem to be problematic), but when I try to call
steps to reproduce:
feel free to close this if not helpful since it doesn't appear to be a peer dep issue. |
@DonGambas oh I see, what version of OnchainKit are you using? And how are you using OnchainKit. The error you have is an old issue, I believe by upgrading to the latest version you should be fine. Also just to triple check, can you please share how you import the code from OnchainKit. |
@Zizzamia I was just running the It does look like the It looks like anything you import from onchainkit throws an error if viem isn't installed. I updated PR with latest version of onchainkit and viem and no issue. There's probably a longer term solution to this (linking parent package version to sibling package deps so they're always up to date), but for now these changes appear to resolve the issue, but I might be missing something.
|
Thank you for this upgrade!!! Oh, so I think we can get rid of Viem as well, if you import from So you do
That's good to know, I need to document Btw, thank you again for going after those bugs. Really appreciated. |
Long story short, OnchainKit will have several dependencies depending of the feature you need. So to make imports more clean we started recently exploring with namespaces. BUT we don't want to break existing app, so we kept the original imports as they are. Eventually when we will bump from v0 to v1, we will make a clean breaking changes. |
Merging this, as it is already a good progress, and do a quick follow up on my own. |
awesome, thanks for the clear explanation of how this is evolving, moving towards using more namespaces makes complete sense. |
What changed? Why?
added below dependencies to the
package.json
in the framegear package. these are required peer dependencies by@coinbase/onchainkit
Notes to reviewers
when running framegear for the first time warnings are raised for the above 3 dependencies. can either add them here to the package.json or add note in documentation that they need to be installed before running framegear.
How has it been tested?
after adding these deps warnings are not raised when installing deps with yarn.