chore: pin onchainkit, update aspect ratio classname #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Pinning onchainkit within
framegear, I think having the caret is what made it so that different people saw different results (e.g., regardingviemimport) (even though the caret shouldn't have any impact pre-1.0 for non-patch versions 🤷♂️)Additionally, #185 pointed out that that was a bug in the aspect ratio classnames. I always forget this, but tailwind needs to see the full dynamic classnamein order to generate it, so
aspect-[1/1]wasn't doing anything because that literal string never showed up.Notes to reviewers
How has it been tested?