[Framegear] Add support for post_redirect, link + icons
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR addresses some items listed in the following roadmap: #146 |
Zizzamia
reviewed
Feb 28, 2024
| <div className="flex flex-col gap-4"> | ||
| <FrameInput /> | ||
| <Frame /> | ||
| <RedirectModalProvider> |
cnasc
reviewed
Feb 28, 2024
| > | ||
| <span className="block max-w-full overflow-hidden text-ellipsis whitespace-nowrap"> | ||
| {children} | ||
| {button?.action === 'post_redirect' || button?.action === 'link' ? ( | ||
| <ArrowTopRightIcon className="ml-1 inline" /> |
There was a problem hiding this comment.
We should probably pick a distinct icon for each case (not a blocker for this PR, can be done in future)
cnasc
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
post_redirect,linkactions.post_redirect,linkbuttons.Screenshot
Notes to reviewers
N/A
How has it been tested?
Manually