feat: transform raw data into FrameMetadata (framegear) #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
So far we've been working with the frame data just as a
Record<string, string>
which causes some unnecessary verbosity and offers the opportunity for typos to lead to runtime errors.I think it would make sense for framegear to take advantage of the
FrameMetadata
type that@coinbase/onchainkit
provides. After validation, we can pass the results into this converter function and then components can operate on known structured data. This lets us compartmentalize the error prone indexing into the base record into one function.While I was in there I:
@coinbase/onchainkit
to latest to get the latest type definitionsstate
Notes to reviewers
Putting this up as draft for now, don't want to change the code too radically to use this just yet. Open to thoughts on this direction
How has it been tested?