feat: add tx as a Frame action option
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ export function convertToFrame(json: any) { | |||
| */ | |||
| export type FrameButtonMetadata = | |||
| | { | |||
| action: 'link' | 'mint'; | |||
| action: 'link' | 'mint' | 'tx'; | |||
There was a problem hiding this comment.
tiny nitpick: can we have txn instead of tx (Texas?)
There was a problem hiding this comment.
That's a great point!
OnchainKit will follow the Frame spec https://warpcast.notion.site/Frame-Transactions-Public-Draft-v2-9d9f9f4f527249519a41bd8d16165f73
if they change it to txn, we will do too.
Feel free to ask there if they will consider txn vs tx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added
txas a Frame action option, enabling support for Frame Transactions.Spec: https://warpcast.notion.site/Frame-Transactions-Public-Draft-v2-9d9f9f4f527249519a41bd8d16165f73
Notes to reviewers
How has it been tested?