Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for FrameTransactionEthSendParams.data replaced Address with Hex #224

Merged
merged 1 commit into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-crabs-pretend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@coinbase/onchainkit': patch
---

- **fix**: for `FrameTransactionEthSendParams.data` replaced `Address` with `Hex`. By @zizzamia #224
2 changes: 1 addition & 1 deletion site/docs/pages/frame/types.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ type FrameTransactionResponse = {
```ts
type FrameTransactionEthSendParams = {
abi: Abi; // The contract ABI for the contract to call.
data?: Address; // The data to send with the transaction.
data?: Hex; // The data to send with the transaction.
to: Address; // The address of the contract to call.
value: bigint; // The amount of Ether to send with the transaction.
};
Expand Down
4 changes: 2 additions & 2 deletions src/frame/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Abi, Address } from 'viem';
import type { Abi, Address, Hex } from 'viem';
import { NeynarFrameValidationInternalModel } from '../utils/neynar/frame/types';

/**
Expand Down Expand Up @@ -154,7 +154,7 @@ export type FrameTransactionResponse = {
*/
export type FrameTransactionEthSendParams = {
abi: Abi; // The contract ABI for the contract to call.
data?: Address; // The data to send with the transaction.
data?: Hex; // The data to send with the transaction.
to: Address; // The address of the contract to call.
value: string; // The amount of Wei to send with the transaction
};
Expand Down
2 changes: 1 addition & 1 deletion src/version.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const version = '0.9.11';
export const version = '0.9.12';
Loading