feat: factor out parseFrameMessage #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasc
commented
Jan 28, 2024
| if (result.isOk() && result.value.valid && result.value.message) { | ||
| validatedMessage = result.value.message; | ||
| } | ||
| const validatedMessage = await parseFrameMessage(body); |
There was a problem hiding this comment.
maybe we want to make this a param? That way if you're parsing the message to get other data anyway you can just pass the result in to this function rather than loading same data twice. Could do this with an overload
cnasc
force-pushed
the
cjn/parseFrameMessage
branch
from
cdd1d6e to
6650977
Compare
Zizzamia
approved these changes
Jan 28, 2024
|
Ehm @robpolak's tests are broken in this PR edit: actually maybe they were already broken? Looks like the mock always returns a user from Neynar so the second test will always fail? |
|
😅 @cnasc can you help us get on a solid testing case, so that we can add it in CI, and than deploy, please. Ideally would be dope to release a new OnchainKit version in the next couple of hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
While working with frames, it's beneficial to be able to get the whole validated message. Since we parse and validate the message as part of
getFrameAccountAddress, I pulled the relevant code out into a new function.Notes to reviewers
How has it been tested?
yolo'd this, would love to hear any strategies for testing
edit: did manually test in a frame by copying code over and it appears to work