feat: Inter fonts #506
Merged
feat: Inter fonts #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Zizzamia
reviewed
Jun 10, 2024
site/docs/pages/App.tsx
Outdated
| @@ -32,7 +32,9 @@ export default function App({ children }: { children: ReactNode }) { | |||
| return ( | |||
| <WagmiProvider config={wagmiConfig}> | |||
| <QueryClientProvider client={queryClient}> | |||
| <div style={{ display: 'flex', flexDirection: 'column' }}>{children}</div> | |||
| <div style={{ display: 'flex', flexDirection: 'column' }} className="ock-docsite-content"> | |||
There was a problem hiding this comment.
Do we want all our demo to shocase Inter?
There was a problem hiding this comment.
Great question. Let's check in with design tomorrow
|
@kyhyco I don't think the font applied is Inter? Here's Inter: https://fonts.google.com/specimen/Inter 
|
kyhyco
force-pushed
the
ky.lee/feat/fonts
branch
from
072e47e to
86498b2
Compare
kyhyco
force-pushed
the
ky.lee/feat/fonts
branch
from
86498b2 to
4ef3dc3
Compare
kyhyco
force-pushed
the
ky.lee/feat/fonts
branch
from
4ef3dc3 to
8b55fa0
Compare
Zizzamia
reviewed
Jun 13, 2024
src/text/TextBody.tsx
Outdated
| @@ -0,0 +1,9 @@ | |||
| import { ReactNode } from 'react'; | |||
|
|
|||
There was a problem hiding this comment.
Oh I see, you are trying to create an internal Design System to use for building all those pieces.
got it!
There was a problem hiding this comment.
We could also do something like src/internal/text
kyhyco
force-pushed
the
ky.lee/feat/fonts
branch
from
8b55fa0 to
c207985
Compare
Zizzamia
approved these changes
Jun 13, 2024
kyhyco
force-pushed
the
ky.lee/feat/fonts
branch
from
bf25c43 to
1ba906f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Interfont to doc siteExample
Notes to reviewers
Tried out several approaches:
importing
@fontsource/inter: messes up the css import path and will require creating a separate package just to handle fonts if we go this routeincluding Inter font files in OnchainKit: this could be an alternative if we don't want to directly hit google fonts
using
@tailwind/componentsto create custom font components: much better to create a react componentUse case for tailwind and non-tailwind users is supported in this PR
How has it been tested?
locally