chore: Add token amount formatter #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcrane123
commented
Jun 13, 2024
| // Convert the string amount to a number using decimals value | ||
| const numberAmount = Number(amount) / Math.pow(10, decimals); | ||
| // Round to a maximum of 11 significant digits | ||
| const roundedAmount = Number(numberAmount.toPrecision(11)); |
There was a problem hiding this comment.
i round to 11 digits here so that the amount will fit in the input but let me know if there is another standard we should follow
There was a problem hiding this comment.
Let's merge this, but I would like the team feedback on what's best. In particular from Jordan Frankfurt and Conner.
Zizzamia
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
getSwapQuoteNotes to reviewers
How has it been tested?