feat: Add balance to SwapAmountInput #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zizzamia
reviewed
Jun 13, 2024
| </div> | ||
| <div className="flex w-full items-center justify-between"> | ||
| <TokenChip token={token} /> | ||
| {type === "from" && ( | ||
| <button | ||
| className="flex h-8 w-[58px] max-w-[200px] items-center rounded-[40px] bg-gray-100 px-3 py-2 text-base font-medium not-italic leading-6 text-gray-500" |
There was a problem hiding this comment.
Add the cn utility here so you can split in two line
Zizzamia
reviewed
Jun 13, 2024
| import { cn } from "../../utils/cn"; | ||
| import { SwapContext } from "../context"; | ||
| import type { SwapAmountInputReact } from "../types"; | ||
| import { useBalance, type UseBalanceReturnType } from "wagmi"; |
There was a problem hiding this comment.
split this in two line, one for import useBalance and one for the type.
Zizzamia
reviewed
Jun 13, 2024
| }); | ||
|
|
||
| const roundedBalance = useMemo(() => { | ||
| if (tokenBalanceData?.formatted && token?.address) { |
There was a problem hiding this comment.
This block can be his own utils getRoundedBalance
…issa.crane/token-balance
kyhyco
reviewed
Jun 13, 2024
| @@ -37,6 +40,17 @@ export function SwapAmountInput({ label, token, type }: SwapAmountInputReact) { | |||
| return setFromToken; | |||
| }, [type, setFromToken, setToToken]); | |||
|
|
|||
| const balanceResponse: UseBalanceReturnType = useBalance({ | |||
There was a problem hiding this comment.
think this might only work with eth
There was a problem hiding this comment.
@abcrane123 let's refactor this later today. Thank you @kyhyco
kyhyco
approved these changes
Jun 13, 2024
Zizzamia
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
useBalancehookNotes to reviewers
totokenHow has it been tested?