Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename onchainname component to name #86

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

alvaroraminelli
Copy link
Contributor

What changed? Why?

Rename from OnchainName to Name to make cleaner usage of component in consumer's project.

Notes to reviewers

How has it been tested?

@alvaroraminelli alvaroraminelli marked this pull request as ready for review February 5, 2024 19:21
@alvaroraminelli alvaroraminelli changed the title fix: rename onchainname component to name only fix: rename onchainname component to name Feb 5, 2024
@Zizzamia
Copy link
Contributor

Zizzamia commented Feb 5, 2024

Nice, one neat.
Can you start using yarn changeset when creating a new PR with any change. Btw this one is a minor change when you use yarn changeset.

"@coinbase/onchainkit": minor
---

Rename `OnchainName` component to `Name`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side side note, add the prefix also and more context/colors

- ***feat**: Rename `OnchainName` component to `Name` [add more context]

Copy link
Contributor

@Zizzamia Zizzamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@Zizzamia Zizzamia merged commit dc6f33d into main Feb 6, 2024
7 checks passed
@Zizzamia Zizzamia deleted the alvaroraminelli/rename-onchain-name branch February 6, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants