Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode #977

Merged
merged 9 commits into from
Aug 6, 2024
Merged

feat: dark mode #977

merged 9 commits into from
Aug 6, 2024

Conversation

kyhyco
Copy link
Contributor

@kyhyco kyhyco commented Aug 5, 2024

What changed? Why?

  • add dark mode
light dark
Screenshot 2024-08-05 at 2 03 51 PM Screenshot 2024-08-05 at 2 03 38 PM
Screenshot 2024-08-05 at 2 04 38 PM Screenshot 2024-08-05 at 2 04 54 PM
Screenshot 2024-08-05 at 2 06 59 PM Screenshot 2024-08-05 at 2 07 24 PM
Screenshot 2024-08-05 at 2 08 05 PM Screenshot 2024-08-05 at 2 07 53 PM
Screenshot 2024-08-05 at 2 26 31 PM Screenshot 2024-08-05 at 2 26 08 PM

Notes to reviewers

How has it been tested?
locally

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 10:11pm

@@ -21,7 +21,7 @@ describe('Badge Component', () => {
expect(badge).toHaveStyle(badgeStyle);
expect(badge).toHaveClass('bg-ock-primary');
const ticker = screen.queryByTestId('ockBadgeTicker');
expect(ticker).toHaveClass('fill-inverse');
expect(ticker).toHaveClass('fill-ock-inverse');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

/>
<path
d="M10.99 8.01001C12.21 8.04001 13.3 8.80001 13.73 9.95001L16 16H0L2.27 9.95001C2.7 8.80001 3.79 8.03001 5.01 8.01001C5.05 8.04001 6.37 9.00001 8 9.00001C9.63 9.00001 10.95 8.04001 10.99 8.01001Z"
fill="#0A0B0D"
className={fill.defaultReverse}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

scrollbar-color: #d1d5db #ffffff;
}

/* Shadow */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looooooooove the comments

@@ -9,46 +10,6 @@ export default {
fontFamily: {
display: 'DM Sans, sans-serif',
},
fill: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we don't need this anymore?

@@ -1,4 +0,0 @@
.ock-scrollbar {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

fill="#0A0B0D"
/>
</svg>
{closeSvg}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so clean

{token.symbol}
</span>
)}
</span>
</span>
<span
data-testid="ockTokenRow_Amount"
className={cn(text.body, 'text-foreground-muted')}
className={cn(text.body, color.foregroundMuted)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix

@@ -27,7 +27,7 @@ export const pressable = {
'cursor-pointer bg-ock-primary active:bg-ock-primary-active hover:bg-ock-primary-hover',
secondary:
'cursor-pointer bg-ock-secondary active:bg-ock-secondary-active hover:bg-ock-secondary-hover',
shadow: 'shadow-[0px_8px_12px_0px_#5B616E1F]',
shadow: 'shadow-ock-default',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

@Zizzamia Zizzamia merged commit a0124f3 into main Aug 6, 2024
14 checks passed
@Zizzamia Zizzamia deleted the ky.lee/feat/dark-mode branch August 6, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants