Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Base avatar support, Fallback to Mainnet #986

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

kirkas
Copy link
Contributor

@kirkas kirkas commented Aug 6, 2024

What changed? Why?

  • feat: Add chain props to useAvatar and getAvatar to resolve Base avatar.
  • feat: Modify getAvatar to resolve Base avatar, and fallback to mainnet if none is found.
image

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 5:06pm

@@ -50,4 +57,81 @@ describe('useAvatar', () => {
expect(result.current.isLoading).toBe(true);
});
});

it('return correct base mainnet avatar', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice tests

@Zizzamia Zizzamia merged commit 0351295 into main Aug 7, 2024
14 checks passed
@Zizzamia Zizzamia deleted the feat-basename-avatar branch August 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg: identity
Development

Successfully merging this pull request may close these issues.

2 participants