chore: Refine Wallet UI - Update dropdown, badges, and text. #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Aug 6, 2024
| @@ -84,7 +81,6 @@ export function WalletComponents() { | |||
| <Identity className="px-4 pt-3 pb-2" hasCopyAddressOnClick> | |||
| <Avatar /> | |||
| <Name> | |||
| <Badge /> | |||
There was a problem hiding this comment.
Something is missing here? :)
I let you guess what's missing
There was a problem hiding this comment.
Hmm do we want it displayed as <Name />
There was a problem hiding this comment.
haha sweet, that's the only thing I could think of 😆
cpcramer
force-pushed
the
paul/simplify-wallet-dropdown-copy
branch
from
ba2abfe to
217c0de
Compare
cpcramer
changed the title
cpcramer
changed the title
cpcramer
force-pushed
the
paul/simplify-wallet-dropdown-copy
branch
from
d617f96 to
bab9fe6
Compare
git
cpcramer
force-pushed
the
paul/simplify-wallet-dropdown-copy
branch
from
a4295e6 to
b62b16b
Compare
Zizzamia
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
<Badge />from Wallet docs as it creates confusion because it is missing the schemaID.Go to Wallet DashboardtoWallet.Notes to reviewers
How has it been tested?