Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a contributing guide along with updates to README #20

Merged
merged 3 commits into from
May 8, 2024
Merged

Add a contributing guide along with updates to README #20

merged 3 commits into from
May 8, 2024

Conversation

drohit-cb
Copy link
Contributor

This PR helps:

  1. Update the README to better provide more accurate steps for anyone to come and follow the quickstart guide.
  2. Adds a contribution guide along with a github PR template similar to the recently added one in our ts client here

@drohit-cb drohit-cb requested a review from ProfMoo May 8, 2024 17:54
@drohit-cb drohit-cb marked this pull request as ready for review May 8, 2024 17:54
ProfMoo
ProfMoo approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ProfMoo ProfMoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small suggestion.

README.md Outdated Show resolved Hide resolved
@drohit-cb @ProfMoo
Update README.md
78862ed 
Co-authored-by: Shane O'Brien <[email protected]>
@drohit-cb drohit-cb merged commit faa897e into main May 8, 2024
3 checks passed
@drohit-cb drohit-cb deleted the updates branch May 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfMoo ProfMoo ProfMoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drohit-cb @ProfMoo