Remove requirement of providing an explicit staking target #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drohit-cb
force-pushed
the
remove_project_id_and_staking_target_requirement
branch
from
412405a to
5098d29
Compare
marcin-cb
approved these changes
May 2, 2024
ProfMoo
reviewed
May 2, 2024
| @@ -153,6 +180,28 @@ client.Ethereum.listRewards(filter).then((resp) => { | |||
|
|
|||
| </details> | |||
|
|
|||
| ## Build | |||
There was a problem hiding this comment.
Maybe we can make a Contributing.md and link that doc here? That way, someone who is trying to build/contribute to this codebase can refer to a different file than someone trying to use it. My preference would be to keep the top-level README as concise as possible.
There was a problem hiding this comment.
Yes, lets do that in a separate PR
deangalvin-cb
approved these changes
May 2, 2024
drohit-cb
added a commit
to coinbase/staking-client-library-go
that referenced
this pull request
May 2, 2024
This PR is counterpart to coinbase/staking-client-library-ts#20 It helps remove the requirement to provide an explicit staking target (integrator contract address for ethereum partial staking and validator address for sol) while making staking api calls. As we move to a self-service world, we want customers to be able to just come and stake to default staking targets i.e. default integration contracts on both Holesky and Mainnet in the case of Partial ETH staking and default coinbase validators on both Devnet and Mainnet in the case of sol staking. As a result, we have updated the examples to not take integrator contract or validator address as required inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps remove the requirement to provide an explicit staking target (integrator contract address for ethereum partial staking and validator address for sol) while making staking api calls.
As we move to a self-service world, we want customers to be able to just come and stake to default staking targets i.e. default integration contracts on both Holesky and Mainnet in the case of Partial ETH staking and default coinbase validators on both Devnet and Mainnet in the case of sol staking.
As a result, we make the integrator contract address validator address an optional filed. When not set, the backend defaults that network's default staking target. For Partial ETH staking, customers that have worked with us to get a dedicated contract deployed, we default to their specific integrator contract address.