Client interface updates #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contruction workflow name from it
…coded wallet where it doesn't make sense
drohit-cb
force-pushed
the
client_interface_updates
branch
from
9ba38c4 to
e6b114c
Compare
marcin-cb
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Change
The ts client currently has an interface where for APIs like
getWorkflowandperformWorkflowStepit expects the user to pass a workflow id. This forces a user to parse out the workflow.name and get it from there. Instead what's easier is, the client interface takes the workflow name as input. One less thing the caller needs to worry about.Testing Procedure
Ran
ts-node examples/solana/create-and-process-workflow.tswith appropriate input, to verify if all works.