Support elixir 1.15.7-otp-26 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe you could also update the README that the reason for forking this library is because of the Elixir upgrade? |
edgarmiadzieles
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why Forked Repo?
Statix Compatibility: Statix, does not yet support OTP-26. It is using
Port.commandinstead of:gen_udp.send, as the former was considered more performant for OTP 25 and older versions. However, due to OTP updates occurring at the networking layer, this approach no longer works. Now,gen_udp.sendhas been optimized, rendering the previous workaround obsolete.References
Open PR: There is an open pull request in the Statix repository addressing this issue: Pull Request #72. This PR aims to update the codebase to support OTP-26 and utilize the optimized
gen_udp.sendfunction.Erlang Discussion: For further insights, you can refer to the Erlang discussion about the breaking change in
Port.commandfor OTP-26: Issue #7130.By utilizing the forked repository of Statix, we can maintain compatibility with OTP-26. As Statix evolves and potentially adds support for our current version, we aim to transition back to the main Statix repository. Alternatively, we'll explore alternatives should the need arise in the future.