Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data on main chart doesn't update (for ages) when changing currencies #178

Closed
lyricnz opened this issue Sep 25, 2021 · 4 comments
Closed

Data on main chart doesn't update (for ages) when changing currencies #178

lyricnz opened this issue Sep 25, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@lyricnz
Copy link
Collaborator

lyricnz commented Sep 25, 2021

  1. Open main view in USD: (top of screen) Market cap ~$2b; (first row in table) BTC ~$42.7
  2. Hit C 0 (AUD)
  3. Market cap immediately changes to $2.7b, BTC takes a minute or two to change
  4. Exit and restart, table updated immediately
@lyricnz
Copy link
Collaborator Author

lyricnz commented Sep 25, 2021

Video of this issue (actually changing AUD->USD)
https://user-images.githubusercontent.com/122371/134755716-bb308d52-819c-4b07-b595-92ad2876cffe.mov
Make more apparent because no visual indicator that a change is pending - see #174

@miguelmota miguelmota added the bug Something isn't working label Sep 26, 2021
@lyricnz
Copy link
Collaborator Author

lyricnz commented Oct 14, 2021

Perhaps we could use client-side currency conversion in some cases? This was done recently to work around an API issue
https://github.com/cointop-sh/cointop/pull/209/files#diff-92ed39eadc12477ac0fcd3f82a69a7e9f0f7a6d5f329273c412a76030e74e9ec

@lyricnz lyricnz mentioned this issue Oct 21, 2021
Merged
@lyricnz
Copy link
Collaborator Author

lyricnz commented Oct 25, 2021

Caused because the current screen doesn't refresh immediately, but waits for the background refresh to cycle around all the coins. #255

lyricnz added a commit to lyricnz/cointop that referenced this issue Oct 25, 2021
@lyricnz
Immediately after changing currency refresh the current coins cointop…
24a2d8f 
…-sh#178
lyricnz added a commit that referenced this issue Oct 29, 2021
@lyricnz
Immediately after changing currency refresh the current coins #178 (#256
19561ce 
)
@lyricnz
Copy link
Collaborator Author

lyricnz commented Nov 7, 2021

Fixed in #232

@lyricnz lyricnz closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyricnz @miguelmota