-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for purchase price/currency to portfolio #243
Conversation
eg: ["Algorand", "125.4", "0.8", "USD"] Add optional (default off) columns to portfolio: "buy_price", "buy_currency", "profit", "profit_percent" TODO: - currency conversion - (maybe) merge price/currency into one column - add to "cointop holdings" output - column sorting shortcuts
With the following config
|
Added "cost" and changed some of the formatting.
|
Nice! I Think in the next step it would also be interesting to add the date the purchase was made, so one can see the differences in performance over time - I don't think, though, that this should go in the same PR, should it? (Of course the maintainers have to decide!) |
I don't know how to make new edit fields, and in fact are in the middle of a radical overhaul of color/keybinding in another PR. Can you test this PR, see if it works for you? (or help?) There are still some todo's here, in particular currency conversion. |
…intop into feature/portfolio-buy
There's still an issue with changing currency conversion - it takes a while for the table to update, so the numbers are wrong for a bit. |
The slow-update is caused by #178 which has to do with updating all the pages of coins, one after another, before going back to the top. I think this PR is ready for review. Will raise feature-requests for pnl-alerts and pnl "cointop holdings" output. |
Renamed and combined buy-price and buy-currency to "cost price". With the following portfolio (cost in diverse currencies) and column configuration, and the currency set to GBP (British Pound).
it looks like this: |
Oh! There's still no support for editing the cost price in the UI. I have no idea how to do this yet. |
Oops, I didn't notice your commits weren't in this branch/PR, but were in another! I tried to update your branch from but got all kinds of conflicts, so I create a new branch and cherry-picked the two commits above. Hope this is OK! #250 |
sorry about that! I didn't realize that it was in a different branch. The other PR looks good @lyricnz |
Add support for declaring a BuyPrice and BuyCurrency in portfolio.
eg: ["Algorand", "125.4", "0.8", "USD"]
Add optional (default off) columns to portfolio:
"buy_price", "buy_currency", "profit", "profit_percent"
TODO: