Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of sass (1.68.0) broke the build #544

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 22, 2023

We've tested your project with an updated dependency and the build failed.

This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.

name version specification new version
sass ^1.62.1 1.68.0

Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.

If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)

We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of sass for this test run.

What changed?

✳️ sass (^1.62.1 → 1.68.0) · Repo · Changelog

Release Notes

1.68.0

To install Sass 1.68.0, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.

Changes

  • Fix the source spans associated with the abs-percent deprecation.

JS API

  • Non-filesystem importers can now set the nonCanonicalScheme field, which declares that one or more URL schemes (without :) will never be used for URLs returned by the canonicalize() method.

  • Add a containingUrl field to the canonicalize() and findFileUrl() methods of importers, which is set to the canonical URL of the stylesheet that contains the current load. For filesystem importers, this is always set; for other importers, it's set only if the current load has no URL scheme, or if its URL scheme is declared as non-canonical by the importer.

Dart API

  • Add AsyncImporter.isNonCanonicalScheme, which importers (async or sync) can use to indicate that a certain URL scheme will never be used for URLs returned by the canonicalize() method.

  • Add AsyncImporter.containingUrl, which is set during calls to the canonicalize() method to the canonical URL of the stylesheet that contains the current load. This is set only if the current load has no URL scheme, or if its URL scheme is declared as non-canonical by the importer.

Embedded Sass

  • The CalculationValue.interpolation field is deprecated and will be removed in a future version. It will no longer be set by the compiler, and if the host sets it it will be treated as equivalent to CalculationValue.string except that "(" and ")" will be added to the beginning and end of the string values.

  • Properly include TypeScript types in the sass-embedded package.

See the full changelog for changes in earlier releases.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-wordpress-starter ❌ Failed (Inspect) Sep 22, 2023 4:21am

@depfu
Copy link
Contributor Author

depfu bot commented Oct 7, 2023

Closed in favor of #549.

@depfu depfu bot closed this Oct 7, 2023
@depfu depfu bot deleted the depfu/check/npm/sass-1.68.0 branch October 7, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants