Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exception handling in tests #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better exception handling in tests #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions colcon_core/task/python/test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def add_arguments(self, *, parser): # noqa: D102
add_python_testing_step_arguments(parser)

async def test(self, *, additional_hooks=None): # noqa: D102
pkg = self.context.pkg
args = self.context.args

logger.info(
Expand Down Expand Up @@ -59,8 +58,7 @@ async def test(self, *, additional_hooks=None): # noqa: D102
'Exception in Python testing step extension '
"'{extension.STEP_TYPE}': {e}\n{exc}"
.format_map(locals()))
# skip failing extension, continue with next one
continue
return 1
if matched:
break
else:
Expand Down