Improve Python install path detection #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roehling
added a commit
to roehling/ament_cmake
that referenced
this pull request
Nov 27, 2023
[ This is the companion PR to colcon/colcon-core#601 ] This PR makes the customized Python path scheme logic in ament_cmake_python contingent on an install prefix other than `/usr`. This makes ament more distribution-friendly and prevents the accidental overwriting of system packages in case someone decides to install their Python packages to /usr. There is no other change in behavior. Signed-off-by: Timo Röhling <[email protected]>
|
(Discussion on how to move forward with this change is ongoing in ament/ament_cmake#496) |
roehling
added a commit
to roehling/ament_cmake
that referenced
this pull request
Feb 21, 2024
[ This is the companion PR to colcon/colcon-core#601 ] This PR makes the customized Python path scheme logic in ament_cmake_python contingent on an install prefix other than `/usr`. This makes ament more distribution-friendly and prevents the accidental overwriting of system packages in case someone decides to install their Python packages to /usr. There is no other change in behavior. Signed-off-by: Timo Röhling <[email protected]>
This PR makes the customized Python path scheme logic in colcon contingent on an install prefix other than `/usr`. This makes colcon more distribution-friendly and prevents the accidental overwriting of system packages in case someone decides to install their packages to `/usr`. There is no other change in behavior. Signed-off-by: Timo Röhling <[email protected]>
roehling
force-pushed
the
python-install-dir
branch
from
415b67a
to
5359d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the customized Python path scheme logic in colcon contingent on an install prefix other than
/usr.This makes colcon more distribution-friendly and prevents the accidental overwriting of system packages in case someone decides to install their packages to
/usr. There is no other change in behavior.