Add support to logging directory setup for no verb #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly support "no verb" in the logging directory setup, as opposed to treating it as an empty string or raising an exception.
cottsay
force-pushed
the
cottsay/log-path-no-verb
branch
from
1363008
to
01eee7c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
=======================================
Coverage 87.26% 87.27%
=======================================
Files 67 67
Lines 3904 3906 +2
Branches 773 774 +1
=======================================
+ Hits 3407 3409 +2
Misses 391 391
Partials 106 106 ☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly support "no verb" in the logging directory setup, as opposed to treating it as an empty string or raising an exception.