fix transient hint when DBus reports different signature #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveMacenski Just FYI. |
delete-merged-branch
bot
deleted the
dirk-thomas/fix-transient-diff-signature
branch
|
The latest comment suggests that this patch doesn't address the problem when the signature mismatches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #46. Based on this question: https://answers.ros.org/question/362449/colcon-builds-but-gives-errordbusconnectionunable-to-set-arguments/
If DBus reports the signature as
susssasa{ss}ithe current code results in aTypeError: Expected a string or unicode objectsince the hint value isn't a string /s. It does work when the signature is reported assusssasa{sv}iwhich allows a variant type for the hint value.This patch uses
set_hint_byte()which hopefully works around the problem.