ignore cmake projects #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Can I check whether a fix like this would work? Basically checking whether there is a build type specified in the package.xml and using it instead? |
|
That sounds like the right way to do it. I would also expect an explicit build type to override any detection. |
|
#10 has been merged as an alternative fix, closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The r2r project still uses CMake for building the nodes in the minimal node example. This PR ignores packages containing
CMakeLists.txtto allow both libraries to be used for writing ROS nodes.The plugin still can compile the r2r node but it leads to problems as described here. I don't really understand the need for colcon-cargo and colcon-ros-cargo at the same time as described in the ros2_rust Readme so I did the PR at both repositories. It seems like the relevant plugin for my system is colcon-ros-cargo though.