Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event hook fix #288

Closed
wants to merge 8 commits into from
Closed

Event hook fix #288

wants to merge 8 commits into from

Conversation

dajt1725
Copy link
Contributor

Make device_changed and job_failed event_hook calls work.

@coldfix
Copy link
Owner

coldfix commented Apr 29, 2024

Hi,
I wouldn't consider this a fix, but rather a new feature.
Introducing a fake device property to provide job properties doesn't really make sense. A job is not part of the device, it is what changes a device.
Just curious, what you're trying to achieve, and if it might be better for you to implement your own udisks client instead of getting too involved on the level of installing hooks from udiskie, see https://github.com/coldfix/udiskie/wiki/Python-API for a minimal example.

@coldfix coldfix closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants