Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inception_cov instead of covariance in PLNnetwork_param? #33

Open
rwelling520 opened this issue Nov 14, 2024 · 2 comments
Open

inception_cov instead of covariance in PLNnetwork_param? #33

rwelling520 opened this issue Nov 14, 2024 · 2 comments

Comments

@rwelling520
Copy link

Ran into an error when running new_cell_count_model:

Error in PLNmodels::PLNnetwork_param(backend = backend, trace = ifelse(verbose, :
unused argument (covariance = covariance_type)

I looked up the source code for new_cell_count_model and checked the allowed inputs for PLNnetwork_param and noticed that that function takes an inception_cov instead of covariance input. Maybe I'm using a different version or something?

https://github.com/cole-trapnell-lab/hooke/blob/2f6ca921fb0e19c9e08a45ec22628d4f57bbbf05/R/cell_count_model.R#L660C77-L660C104

@rfriedman22
Copy link
Collaborator

You're correct about the error here. PLNnetwork_param has been updated and no longer takes the covariance argument. We have made this change on the develop branch but not on main. I tried to make a quick patch on the main branch, but I don't have permissions on that branch. I'm waiting for them now. You could try to install the develop branch of Hooke instead, which will work, but there might be other things that are different compared to what you're used to using.

@rwelling520
Copy link
Author

Thanks @rfriedman22 :)

maddyduran added a commit that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants