Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes to conversion functions to/from Seurat objects #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewwbutler
Copy link

Changes to importCDS

  • convert raw.data slot to a matrix to allow conversion to AnnotatedDataFrame
  • subset raw.data slot to only cells that are summarized in meta.data
  • more robust check for matrix of integers (could be matrix of 'numeric' class entries but are still integer values) when determining the expressionFamily

Changes to exportCDS

  • Use CreateSeuratObject instead of new class constructor so that normalization/scaling procedures are consistent and other slots are populated correctly (cell.names)

@Xiaojieqiu
Copy link
Collaborator

Hi Andrew,

Thanks for your pull request! I actually made the changes as you suggested yesterday. But because we are waiting for the monocle to be built on the bioconductor and thus have not replied you back. Sorry about this. I will check your PR and my changes to merge them soon.

Thanks again!

@andrewwbutler
Copy link
Author

Ok no worries. Just wanted to make sure you had something to work with. At least in my experience, things tend to get a bit hectic around releases 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants