Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D9 - Set default currency on the contribution tab #896

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

jitendrapurohit
Copy link
Collaborator

Overview

Save button does nothing is currency is not set to any value.

Before

Currency field is required. If user fails to set it and navigates to another tab (eg Membership) & saves the webform => nothing happens and console returns the following error:

image

This is because the Contribution tab is not active on the browser. Saving the form now has required validation error on the invisible field.

After

Default currency is pre-selected.

image

Comments

Drupal Ticket - https://www.drupal.org/project/webform_civicrm/issues/3375985

@petednz
Copy link

petednz commented Jul 24, 2023

Tested - sets currency to default. thx

@mattwire
Copy link
Collaborator

@KarinG good to merge

@jitendrapurohit jitendrapurohit merged commit 7920e4e into colemanw:6.x Aug 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants